[#2856] fix(core): Fix the namespace missing issue when get entities from kv storage #2971
Conversation
|
I noticed that you only set the namespace value when deserialization and will not store the value in the key-value store. My question is: Why do we have to change the interface |
| @@ -539,7 +539,8 @@ tasks.rat { | |||
| "**/LICENSE.*", | |||
| "**/NOTICE.*", | |||
| "ROADMAP.md", | |||
| "clients/client-python/.pytest_cache/*" | |||
| "clients/client-python/.pytest_cache/*", | |||
| "clients/client-python/gravitino.egg-info/*" | |||
There was a problem hiding this comment.
This folder does not exist on my local machine, can anyone help to confirm this point?
There was a problem hiding this comment.
Try gradle build.
You can check the issue to know the details. Simply, it is because the deserialized entity from KV has an empty namespace, but for catalog like kafka needs to get namespace from entity to use, and it cannot get a namespace from context (caller), you can see KafkaOperation's CatalogInfo (CatalogEntity). Besides, for relational store, they all have namespace set when get from interface, so it is also a behavior alignment. |
I see, let me check again |
What changes were proposed in this pull request?
This PR fixes the namespace missing issue when entities are gotten from kv storage.
Why are the changes needed?
Fix: #2856
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified UTs.